Enable multi-release attribute for Spark job server jar#38449
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Spark job server build configuration to enable multi-release JAR support. It also cleans up a previous workaround related to gradle caching, streamlining the build process for the shadow jar. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
R: @tkaymak |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the shadowJar task configuration in spark_job_server.gradle by removing a Gradle cache workaround and adding a Multi-Release manifest attribute. The reviewer suggests splitting these logically distinct changes into separate pull requests to improve commit history and maintainability.
| shadowJar { | ||
| outputs.upToDateWhen { false } | ||
| manifest { | ||
| attributes(["Multi-Release": true]) | ||
| } | ||
| } |
There was a problem hiding this comment.
This pull request combines two logically separate changes:
- Removing the Gradle cache workaround (
outputs.upToDateWhen { false }). - Enabling the
Multi-Releasemanifest attribute.
Combining unrelated changes in a single pull request can make the commit history harder to follow and complicates tasks like reverting or cherry-picking commits. It is recommended to submit separate pull requests for each distinct logical change.
Please consider splitting these changes into two separate pull requests.
1 participant
Remove leftover of corrupt gradle cache workaround added before
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.